bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Roll back multi-file saves on partial failure #14

New Issue
Open
opened 2026-06-06 19:58:12 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:12 +00:00
Copy Link

Severity: medium
Category: data-integrity
Location: app.py:1222-1232,1436-1463,1555-1563,1630-1635,2029-2035

Problem

Routes that write two files (debts+bills, funds+weekly) have no rollback; if the second save fails the files are left inconsistent (e.g. BNPL count incremented but bill not marked paid).

Suggested fix

Snapshot pre-mutation state and revert on failure, or consolidate to a single store / SQLite.

Filed by automated code review.

**Severity:** medium **Category:** data-integrity **Location:** `app.py:1222-1232,1436-1463,1555-1563,1630-1635,2029-2035` ### Problem Routes that write two files (debts+bills, funds+weekly) have no rollback; if the second save fails the files are left inconsistent (e.g. BNPL count incremented but bill not marked paid). ### Suggested fix Snapshot pre-mutation state and revert on failure, or consolidate to a single store / SQLite. _Filed by automated code review._
tonym added the
data-integrity
severity:medium
 labels 2026-06-06 19:58:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
data-integrity
severity:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#14
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?