bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Clamp bills due on day 29-31 in short months (calendar drops them) #17

New Issue
Open
opened 2026-06-06 19:58:12 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:12 +00:00
Copy Link

Severity: high
Category: bug
Location: bills.py:62-64

Problem

bills_for_month requires due_day <= num_days, so a bill due on the 31st is invisible in February and missing from totals — yet reminders.py clamps with min() and DOES fire. Inconsistent + understated budget.

Suggested fix

Match reminders.py: actual_day = min(due_day, num_days) and always include the bill.

Filed by automated code review.

**Severity:** high **Category:** bug **Location:** `bills.py:62-64` ### Problem `bills_for_month` requires `due_day <= num_days`, so a bill due on the 31st is invisible in February and missing from totals — yet reminders.py clamps with min() and DOES fire. Inconsistent + understated budget. ### Suggested fix Match reminders.py: `actual_day = min(due_day, num_days)` and always include the bill. _Filed by automated code review._
tonym added the
bug
severity:high
 labels 2026-06-06 19:58:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
bug
severity:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#17
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?