bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Initialize next_num before loop in bnpl_payment (UnboundLocalError 500) #18

New Issue
Open
opened 2026-06-06 19:58:12 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:12 +00:00
Copy Link

Severity: high
Category: bug
Location: app.py:1543-1563

Problem

next_num is only assigned inside the debts loop; if debt_id matches nothing the later reference raises UnboundLocalError (500) after save_debts already ran.

Suggested fix

Set next_num = None before the loop and guard the bills block, like match_bnpl does.

Filed by automated code review.

**Severity:** high **Category:** bug **Location:** `app.py:1543-1563` ### Problem `next_num` is only assigned inside the debts loop; if debt_id matches nothing the later reference raises UnboundLocalError (500) after save_debts already ran. ### Suggested fix Set `next_num = None` before the loop and guard the bills block, like match_bnpl does. _Filed by automated code review._
tonym added the
bug
severity:high
 labels 2026-06-06 19:58:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
bug
severity:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#18
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?