bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Stop load_funds from returning the mutable DEFAULT_FUNDS list #23

New Issue
Open
opened 2026-06-06 19:58:13 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:13 +00:00
Copy Link

Severity: medium
Category: bug
Location: sinking.py:32-33

Problem

On first run it returns the module-level DEFAULT_FUNDS by reference; in-place mutation permanently alters the default for the process lifetime.

Suggested fix

Return copy.deepcopy(DEFAULT_FUNDS).

Filed by automated code review.

**Severity:** medium **Category:** bug **Location:** `sinking.py:32-33` ### Problem On first run it returns the module-level DEFAULT_FUNDS by reference; in-place mutation permanently alters the default for the process lifetime. ### Suggested fix Return `copy.deepcopy(DEFAULT_FUNDS)`. _Filed by automated code review._
tonym added the
bug
severity:medium
 labels 2026-06-06 19:58:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
bug
severity:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#23
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?