bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Align upload save path with the /uploads serving route #25

New Issue
Open
opened 2026-06-06 19:58:14 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:14 +00:00
Copy Link

Severity: medium
Category: bug
Location: app.py:36-38 vs 436

Problem

Imports save to DATA_DIR root but /uploads/ serves from /data/uploads, so imported files are unreachable; and the route exposes the whole dir without validating .

Suggested fix

Save to DATA_DIR/uploads/<secure_filename> and point send_from_directory at the same dir.

Filed by automated code review.

**Severity:** medium **Category:** bug **Location:** `app.py:36-38 vs 436` ### Problem Imports save to DATA_DIR root but /uploads/<path> serves from /data/uploads, so imported files are unreachable; and the route exposes the whole dir without validating <path>. ### Suggested fix Save to `DATA_DIR/uploads/<secure_filename>` and point send_from_directory at the same dir. _Filed by automated code review._
tonym added the
bug
severity:medium
 labels 2026-06-06 19:58:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
bug
severity:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#25
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?