bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Harden income_ytd year filtering (string prefix match) #30

New Issue
Open
opened 2026-06-06 19:58:15 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:15 +00:00
Copy Link

Severity: low
Category: tech-debt
Location: income.py:56

Problem

mk.startswith(str(year)) is fragile and would mismatch malformed month keys, corrupting YTD totals.

Suggested fix

Parse the year: mk.partition('-')[0] != str(year) continue; validate month keys at write time.

Filed by automated code review.

**Severity:** low **Category:** tech-debt **Location:** `income.py:56` ### Problem `mk.startswith(str(year))` is fragile and would mismatch malformed month keys, corrupting YTD totals. ### Suggested fix Parse the year: `mk.partition('-')[0] != str(year)` continue; validate month keys at write time. _Filed by automated code review._
tonym added the
tech-debt
severity:low
 labels 2026-06-06 19:58:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
severity:low
tech-debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#30
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?