bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Define TAX_FILE after DATA_DIR to avoid divergent fallbacks #32

New Issue
Open
opened 2026-06-06 19:58:15 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:15 +00:00
Copy Link

Severity: low
Category: tech-debt
Location: app.py:57 vs 172

Problem

TAX_FILE is built with its own inline DATA_DIR lookup before the canonical DATA_DIR is defined; a future fallback change silently diverges.

Suggested fix

Move TAX_FILE = os.path.join(DATA_DIR, 'taxes.json') below the DATA_DIR definition.

Filed by automated code review.

**Severity:** low **Category:** tech-debt **Location:** `app.py:57 vs 172` ### Problem TAX_FILE is built with its own inline DATA_DIR lookup before the canonical DATA_DIR is defined; a future fallback change silently diverges. ### Suggested fix Move `TAX_FILE = os.path.join(DATA_DIR, 'taxes.json')` below the DATA_DIR definition. _Filed by automated code review._
tonym added the
tech-debt
severity:low
 labels 2026-06-06 19:58:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
severity:low
tech-debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#32
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?