bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Add MAX_CONTENT_LENGTH + content-type check to the PDF/CSV import route #4

New Issue
Open
opened 2026-06-06 19:58:10 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:10 +00:00
Copy Link

Severity: high
Category: security
Location: app.py:425-472

Problem

No upload size limit and no MIME validation; a huge or malformed PDF is streamed into pdfplumber and can exhaust container memory/disk. (The suggestions upload caps at 10MB; this route does not.)

Suggested fix

Set app.config['MAX_CONTENT_LENGTH'] (e.g. 20MB) and validate content_type against an allowlist.

Filed by automated code review.

**Severity:** high **Category:** security **Location:** `app.py:425-472` ### Problem No upload size limit and no MIME validation; a huge or malformed PDF is streamed into pdfplumber and can exhaust container memory/disk. (The suggestions upload caps at 10MB; this route does not.) ### Suggested fix Set `app.config['MAX_CONTENT_LENGTH']` (e.g. 20MB) and validate content_type against an allowlist. _Filed by automated code review._
tonym added the
security
severity:high
 labels 2026-06-06 19:58:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
security
severity:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?