bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Escape input in bold_md filter before wrapping in Markup (stored XSS) #6

New Issue
Open
opened 2026-06-06 19:58:10 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:10 +00:00
Copy Link

Severity: high
Category: security
Location: app.py:43-47

Problem

bold_md regex-substitutes then wraps in Markup(), disabling auto-escaping. Inputs include category names sourced from imported CSV/PDF, so <script> in that data would render unescaped.

Suggested fix

Escape first: re.sub(r'\*\*(.+?)\*\*', r'<strong>\1</strong>', str(markupsafe.escape(text))).

Filed by automated code review.

**Severity:** high **Category:** security **Location:** `app.py:43-47` ### Problem `bold_md` regex-substitutes then wraps in `Markup()`, disabling auto-escaping. Inputs include category names sourced from imported CSV/PDF, so `<script>` in that data would render unescaped. ### Suggested fix Escape first: `re.sub(r'\*\*(.+?)\*\*', r'<strong>\1</strong>', str(markupsafe.escape(text)))`. _Filed by automated code review._
tonym added the
security
severity:high
 labels 2026-06-06 19:58:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
security
severity:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#6
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?