bonna61/Moon-Household-Budget
1
0
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects Releases Wiki Activity

Guard the /suggestions HTML page with the same auth as its API #9

New Issue
Open
opened 2026-06-06 19:58:11 +00:00 by tonym · 0 comments
tonym commented 2026-06-06 19:58:11 +00:00
Copy Link

Severity: low
Category: security
Location: suggestions/routes_flask.py:70-72

Problem

_guard() protects the suggestion API routes but not suggestions_page(). Harmless while current_user() is a stub, but inconsistent once real auth lands.

Suggested fix

Apply the guard/redirect to suggestions_page() too.

Filed by automated code review.

**Severity:** low **Category:** security **Location:** `suggestions/routes_flask.py:70-72` ### Problem `_guard()` protects the suggestion API routes but not `suggestions_page()`. Harmless while current_user() is a stub, but inconsistent once real auth lands. ### Suggested fix Apply the guard/redirect to suggestions_page() too. _Filed by automated code review._
tonym added the
security
severity:low
 labels 2026-06-06 19:58:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
correctness
data-integrity
frontend
infra
security
severity:critical
severity:high
severity:low
severity:medium
tech-debt
No Label
security
severity:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bonna61
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bonna61/Moon-Household-Budget#9
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?