Don't expose raw exceptions to client

This commit is contained in:
Donkie
2023-05-14 10:01:11 +02:00
parent 8b4ba1f1c5
commit 24083b42f9
3 changed files with 22 additions and 8 deletions

View File

@@ -1,5 +1,6 @@
"""Filament related endpoints."""
import logging
from typing import Annotated, Optional
from fastapi import APIRouter, Depends, Query
@@ -14,6 +15,8 @@ from spoolman.database import filament
from spoolman.database.database import get_db_session
from spoolman.exceptions import ItemDeleteError
logger = logging.getLogger(__name__)
router = APIRouter(
prefix="/filament",
tags=["filament"],
@@ -196,9 +199,10 @@ async def delete( # noqa: ANN201
):
try:
await filament.delete(db, filament_id)
except ItemDeleteError as exc:
except ItemDeleteError:
logger.exception("Failed to delete filament.")
return JSONResponse(
status_code=403,
content={"message": str(exc)},
content={"message": "Failed to delete filament, see server logs for more information."},
)
return Message(message="Success!")