Added some basic field CRUD tests

tests_integration/tests/fields/__init__.py

@@ -0,0 +1 @@
+"""Integration tests for the custom extra fields system."""

tests_integration/tests/fields/test_create.py

@@ -0,0 +1,262 @@
+"""Integration tests for the custom extra fields system."""
+
+import json
+from datetime import datetime, timezone
+
+import httpx
+import pytest
+
+from ..conftest import assert_httpx_success
+
+URL = "http://spoolman:8000"
+
+
+def test_add_text_field():
+    """Test adding a text field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mytextfield",
+        json={
+            "name": "My text field",
+            "field_type": "text",
+            "default_value": json.dumps("Hello World"),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/mytextfield")
+    assert_httpx_success(result)
+
+
+def test_add_text_field_filament():
+    """Test adding a text field for filaments."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/filament/mytextfield",
+        json={
+            "name": "My text field",
+            "field_type": "text",
+            "default_value": json.dumps("Hello World"),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/filament/mytextfield")
+    assert_httpx_success(result)
+
+
+def test_add_text_field_vendor():
+    """Test adding a text field for vendors."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/vendor/mytextfield",
+        json={
+            "name": "My text field",
+            "field_type": "text",
+            "default_value": json.dumps("Hello World"),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/vendor/mytextfield")
+    assert_httpx_success(result)
+
+
+def test_add_integer_field():
+    """Test adding an integer field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/myintegerfield",
+        json={
+            "name": "My integer field",
+            "field_type": "integer",
+            "default_value": json.dumps(42),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/myintegerfield")
+    assert_httpx_success(result)
+
+
+def test_add_integer_range_field():
+    """Test adding an integer range field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/myintegerrangefield",
+        json={
+            "name": "My integer range field",
+            "field_type": "integer_range",
+            "default_value": json.dumps([0, 100]),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/myintegerrangefield")
+    assert_httpx_success(result)
+
+
+def test_add_float_field():
+    """Test adding a float field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/myfloatfield",
+        json={
+            "name": "My float field",
+            "field_type": "float",
+            "default_value": json.dumps(3.14),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/myfloatfield")
+    assert_httpx_success(result)
+
+
+def test_add_float_range_field():
+    """Test adding a float range field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/myfloatrangefield",
+        json={
+            "name": "My float range field",
+            "field_type": "float_range",
+            "default_value": json.dumps([0.0, 1.0]),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/myfloatrangefield")
+    assert_httpx_success(result)
+
+
+def test_add_datetime_field():
+    """Test adding a datetime field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mydatetimefield",
+        json={
+            "name": "My datetime field",
+            "field_type": "datetime",
+            "default_value": json.dumps(datetime.now(timezone.utc).isoformat()),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/mydatetimefield")
+    assert_httpx_success(result)
+
+
+def test_add_boolean_field():
+    """Test adding a boolean field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mybooleanfield",
+        json={
+            "name": "My boolean field",
+            "field_type": "boolean",
+            "default_value": json.dumps(True),  # noqa: FBT003
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/mybooleanfield")
+    assert_httpx_success(result)
+
+
+@pytest.mark.parametrize(
+    "multi_choice",
+    [True, False],
+)
+def test_add_choice_field(multi_choice: bool):  # noqa: FBT001
+    """Test adding a choice field for spools."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mychoicefield",
+        json={
+            "name": "My choice field",
+            "field_type": "choice",
+            "choices": ["foo", "bar", "baz"],
+            "default_value": json.dumps(["foo"]) if multi_choice else json.dumps("foo"),
+            "multi_choice": multi_choice,
+        },
+    )
+    assert_httpx_success(result)
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/mychoicefield")
+    assert_httpx_success(result)
+
+
+def test_add_text_field_invalid_data():
+    """Test adding a text field with invalid default value."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mytextfield",
+        json={
+            "name": "My text field",
+            "field_type": "text",
+            "default_value": json.dumps(42),
+        },
+    )
+    assert result.status_code == 400
+    assert result.json()["message"] == "Default value is not valid: Value is not a string."
+
+
+def test_add_choice_field_without_multi_choice():
+    """Test adding a choice field without multi_choice set."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mychoicefield",
+        json={
+            "name": "My choice field",
+            "field_type": "choice",
+            "choices": ["foo", "bar", "baz"],
+            "default_value": json.dumps("foo"),
+        },
+    )
+    assert result.status_code == 400
+    assert result.json()["message"] == "Multi choice must be set for field type choice."
+
+
+def test_add_choice_field_invalid_choices():
+    """Test adding a choice field with invalid choices."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mychoicefield",
+        json={
+            "name": "My choice field",
+            "field_type": "choice",
+            "choices": ["foo", "bar", "baz", {"foo": "bar"}],
+            "default_value": json.dumps(["foo"]),
+            "multi_choice": True,
+        },
+    )
+    assert result.status_code == 422
+
+
+def test_add_choice_field_invalid_default_value():
+    """Test adding a choice field with invalid default value."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mychoicefield",
+        json={
+            "name": "My choice field",
+            "field_type": "choice",
+            "choices": ["foo", "bar", "baz"],
+            "default_value": json.dumps(42),
+            "multi_choice": False,
+        },
+    )
+    assert result.status_code == 400
+    assert result.json()["message"] == "Default value is not valid: Value is not a string."
+
+
+def test_add_choice_field_no_choices():
+    """Test adding a choice field without choices set."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mychoicefield",
+        json={
+            "name": "My choice field",
+            "field_type": "choice",
+            "default_value": json.dumps("foo"),
+            "multi_choice": True,
+        },
+    )
+    assert result.status_code == 400
+    assert result.json()["message"] == "Choices must be set for field type choice."

tests_integration/tests/fields/test_delete.py

@@ -0,0 +1,31 @@
+"""Integration tests for the custom extra fields system."""
+
+import json
+
+import httpx
+
+from ..conftest import assert_httpx_success
+
+URL = "http://spoolman:8000"
+
+
+def test_delete_field():
+    """Test adding a field, deleting it, and making sure it's gone."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mytextfield",
+        json={
+            "name": "My text field",
+            "field_type": "text",
+            "default_value": json.dumps("Hello World"),
+        },
+    )
+    assert_httpx_success(result)
+
+    # Delete
+    result = httpx.delete(f"{URL}/api/v1/field/spool/mytextfield")
+    assert_httpx_success(result)
+
+    # Verify
+    result = httpx.get(f"{URL}/api/v1/field/spool")
+    assert_httpx_success(result)
+    assert result.json() == []

tests_integration/tests/fields/test_get.py

@@ -0,0 +1,60 @@
+"""Integration tests for the custom extra fields system."""
+
+import json
+
+import httpx
+
+from ..conftest import assert_httpx_success, assert_lists_compatible
+
+URL = "http://spoolman:8000"
+
+
+def test_get_field():
+    """Test adding a couple of fields to the spool and then getting them."""
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/mytextfield",
+        json={
+            "name": "My text field",
+            "field_type": "text",
+            "default_value": json.dumps("Hello World"),
+        },
+    )
+    assert_httpx_success(result)
+
+    result = httpx.post(
+        f"{URL}/api/v1/field/spool/myintfield",
+        json={
+            "name": "My int field",
+            "field_type": "integer",
+            "default_value": json.dumps(42),
+        },
+    )
+    assert_httpx_success(result)
+
+    result = httpx.get(f"{URL}/api/v1/field/spool")
+    assert_httpx_success(result)
+    assert_lists_compatible(
+        result.json(),
+        [
+            {
+                "name": "My text field",
+                "key": "mytextfield",
+                "field_type": "text",
+                "default_value": json.dumps("Hello World"),
+            },
+            {
+                "name": "My int field",
+                "key": "myintfield",
+                "field_type": "integer",
+                "default_value": json.dumps(42),
+            },
+        ],
+        sort_key="key",
+    )
+
+    # Clean up
+    result = httpx.delete(f"{URL}/api/v1/field/spool/mytextfield")
+    assert_httpx_success(result)
+
+    result = httpx.delete(f"{URL}/api/v1/field/spool/myintfield")
+    assert_httpx_success(result)